eeeck/CANdigger
1
0
Fork 1
Code Issues 7 Pull Requests 1 Actions Projects 1 Releases 6 Wiki Activity

Remove semaphores in favor of task notifications

Browse Source 
- Less overhead, simpler to manage
- Semaphores are apparently overkill for a simple blink timer
This commit is contained in:
Erick
2026-06-16 17:56:11 +02:00
parent cc3a37ba4b
commit 6446f5209b
3 changed files with 24 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Core/Src/canlog.c
+17 -10
View File
@@ -24,6 +24,9 @@
extern CAN_HandleTypeDef hcan1;
extern CAN_HandleTypeDef hcan2;
extern osThreadId_t xLedTaskCAN1;
extern osThreadId_t xLedTaskCAN2;
/* Private function prototypes -----------------------------------------------*/
/* USER CODE BEGIN FunctionPrototypes */
/* BEGIN CAN_Logger_Init */
@@ -76,15 +79,17 @@ void HAL_CAN_RxFifo0MsgPendingCallback(CAN_HandleTypeDef *hcan)
memcpy(message.payload, data, rxHeader.DLC);
osMessageQueueId_t queue = (hcan->Instance == CAN1) ? xCAN1RxQueue : xCAN2RxQueue;
if (osMessageQueuePut(queue, &message, 0U, 0U) != osOK)
if (osMessageQueuePut(queue, &message, 0U, 0U) == osOK)
{
if (hcan->Instance == CAN1) osThreadFlagsSet(xLedTaskCAN1, 0x01);
else osThreadFlagsSet(xLedTaskCAN2, 0x01);
}
else
{
// TODO: better handling: flash error_led on osTimeout, call Error_Handler() when other errors
// send errors like queue full via UART
}
osSemaphoreId_t semaphore = (hcan->Instance == CAN1) ? xSemaphoreCAN1 : xSemaphoreCAN2;
osSemaphoreRelease(semaphore);
/* CODE END */
}
/* END HAL_CAN_RxFifo0MsgPendingCallback */
@@ -126,12 +131,14 @@ void vLEDHeartbeat(void *argument)
/* CODE BEGIN */
LEDContext *context = (LEDContext*)argument;
for (;;)
{
if (osSemaphoreAcquire(context->semaphore, 25U) == osOK) HAL_GPIO_WritePin(context->led->port, context->led->pin, GPIO_PIN_SET);
else HAL_GPIO_WritePin(context->led->port, context->led->pin, GPIO_PIN_RESET);
}
/* CODE END */
for (;;)
{
uint32_t ret = osThreadFlagsWait(0x01, osFlagsWaitAny, 25U);
if (ret & 0x01) HAL_GPIO_WritePin(context->led->port, context->led->pin, GPIO_PIN_SET);
else HAL_GPIO_WritePin(context->led->port, context->led->pin, GPIO_PIN_RESET);
}
/* CODE END */
}
/* END vLEDHeartbeat */
/* USER CODE END FunctionPrototypes */