From bbdb278338af37ae5a11a642fb2d3871e7721aa2 Mon Sep 17 00:00:00 2001 From: Erick Ahmed Date: Tue, 9 Jun 2026 00:13:20 +0200 Subject: [PATCH] Minor changes on comments - Clarifications on existing comments - Add TODO --- Core/Src/canlog.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Core/Src/canlog.c b/Core/Src/canlog.c index 8163773..36acdbf 100644 --- a/Core/Src/canlog.c +++ b/Core/Src/canlog.c @@ -1,3 +1,4 @@ + #include "canlog.h" #include "cmsis_os.h" #include @@ -65,7 +66,7 @@ void vCAN_log(void *argument) /* BEGIN vLED_HeartbeatOnCanRx */ /** * @brief Blink a LED in heartbeat mode when there is CAN traffic detected. - * @param argument: Not used + * @param argument: LED GPIO * @retval None */ void vLED_HeartbeatOnCanRx(void *argument) @@ -75,9 +76,14 @@ void vLED_HeartbeatOnCanRx(void *argument) for(;;) { + //TODO: add condition -> led High only when CANrx + // else led Low + // Depends on can log functions + // Use semaphore or message queue + HAL_GPIO_TogglePin(led->port, led->pin); vTaskDelay(pdMS_TO_TICKS(100)); } /* CODE END */ } -/* vLED_HeartbeatOnCanRx */ +/* END vLED_HeartbeatOnCanRx */