From f260dfe972cc26648f46ba5ba233e4df1ec08b5e Mon Sep 17 00:00:00 2001
From: Erick Ahmed <engineering@erickahmed.com>
Date: Tue, 16 Jun 2026 18:11:12 +0200
Subject: [PATCH] Use define instead of hardcoded value

---
 Core/Inc/canlog.h | 6 +++++-
 Core/Src/canlog.c | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Core/Inc/canlog.h b/Core/Inc/canlog.h
index 491e696..6334f30 100644
--- a/Core/Inc/canlog.h
+++ b/Core/Inc/canlog.h
@@ -18,9 +18,13 @@
 /* Define to prevent recursive inclusion -------------------------------------*/
 #ifndef CANLOG_H
 #define CANLOG_H
-
+/* Includes ------------------------------------------------------------------*/
 #include "main.h"
 #include "cmsis_os.h"
+/* Private define ------------------------------------------------------------*/
+/* USER CODE BEGIN PD */
+#define LED_BLINK_MS 25U
+/* USER CODE END PD */
 
 extern osMessageQueueId_t xCAN1RxQueue;
 extern osMessageQueueId_t xCAN2RxQueue;
diff --git a/Core/Src/canlog.c b/Core/Src/canlog.c
index 428b1e6..692e1dd 100644
--- a/Core/Src/canlog.c
+++ b/Core/Src/canlog.c
@@ -134,7 +134,7 @@ void vLEDHeartbeat(void *argument)
 
   for (;;)
   {
-    uint32_t notification = osThreadFlagsWait(0x01, osFlagsWaitAny, 25U);
+    uint32_t notification = osThreadFlagsWait(0x01, osFlagsWaitAny, LED_BLINK_MS);
 
     if (notification & 0x01) HAL_GPIO_WritePin(led->port, led->pin, GPIO_PIN_SET);
     else HAL_GPIO_WritePin(led->port, led->pin, GPIO_PIN_RESET);