From 33407980b5b5bc1607222ccd54b60a07d823ee9c Mon Sep 17 00:00:00 2001
From: Erick Ahmed <engineering@erickahmed.com>
Date: Thu, 13 Nov 2025 00:06:32 +0100
Subject: [PATCH] ci: remove login steps from CI pipeline

---
 .github/workflows/ffi-unit-test.yml  | 14 ++++----------
 .github/workflows/occt-unit-test.yml | 24 +++++++++++-------------
 2 files changed, 15 insertions(+), 23 deletions(-)

diff --git a/.github/workflows/ffi-unit-test.yml b/.github/workflows/ffi-unit-test.yml
index 792225a..5f47ef3 100644
--- a/.github/workflows/ffi-unit-test.yml
+++ b/.github/workflows/ffi-unit-test.yml
@@ -38,17 +38,11 @@ jobs:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
-      - name: Login to GitHub Container Registry
-        if: github.event_name != 'pull_request'
-        uses: docker/login-action@v3
+      - name: Download OCCT build artifacts
+        uses: actions/download-artifact@v4
         with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Pull OCCT builder image
-        run: |
-          docker pull ghcr.io/${{ github.repository }}/occt-builder:latest || echo "OCCT image not found, will build from source"
+          name: occt-build-artifacts
+          path: build/
 
       - name: Make script executable
         run: chmod +x ./ci/scripts/ffi.sh
diff --git a/.github/workflows/occt-unit-test.yml b/.github/workflows/occt-unit-test.yml
index 20c33e5..9a2a31d 100644
--- a/.github/workflows/occt-unit-test.yml
+++ b/.github/workflows/occt-unit-test.yml
@@ -1,4 +1,5 @@
 name: OCCT CI
+
 on:
   push:
     branches: [master, dev-occt**]
@@ -33,22 +34,19 @@ jobs:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
-      - name: Login to GitHub Container Registry
-        if: github.event_name != 'pull_request'
-        uses: docker/login-action@v3
-        with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
       - name: Make script executable
         run: chmod +x ./ci/scripts/occt.sh
 
       - name: Build OCCT and run tests
         run: ./ci/scripts/occt.sh --unit-testing
 
-      - name: Tag and push OCCT image
-        if: github.event_name != 'pull_request'
-        run: |
-          docker tag occt-builder:latest ghcr.io/${{ github.repository }}/occt-builder:latest
-          docker push ghcr.io/${{ github.repository }}/occt-builder:latest
+      - name: Upload build artifacts
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: occt-build-artifacts
+          path: |
+            build/
+            **/*.so
+            **/*.a
+          retention-days: 7