From 94589c07d75c5d4387102ccd379782fc94ebc841 Mon Sep 17 00:00:00 2001
From: Stefano Calabretti <StefanoCalabretti@outlook.it>
Date: Sat, 7 May 2022 14:48:54 +0200
Subject: [PATCH 1/3] Cycle mailboxes

---
 Src/mmr_can_send.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/Src/mmr_can_send.c b/Src/mmr_can_send.c
index f92599d..e62c621 100644
--- a/Src/mmr_can_send.c
+++ b/Src/mmr_can_send.c
@@ -23,9 +23,13 @@ static uint8_t computeFramesToSend(MmrCanPacket *packet);
 static uint8_t computeNextMessageLength(MmrCanPacket *packet);
 static void setMessageType(TransmissionParams *header, MmrCanMessageType type);
 static void syncHeaders(TransmissionParams *tp);
+static CanMailbox *getNextMailbox();
 
 
-static CanMailbox __mailbox;
+#define MAILBOXES_COUNT 3
+
+static CanMailbox __mailboxes[MAILBOXES_COUNT] = {};
+static uint8_t __currentMailbox = 0;
 
 
 HalStatus MMR_CAN_Send(CanHandle *hcan, MmrCanPacket packet) {
@@ -108,11 +112,16 @@ static HalStatus send(TransmissionParams *tp) {
     tp->handle,
     &tp->headers.tx,
     tp->packet->data,
-    &__mailbox
+    getNextMailbox()
   );
 }
 
 
+static CanMailbox *getNextMailbox() {
+  return &__mailboxes[__currentMailbox++ % MAILBOXES_COUNT];
+}
+
+
 static void syncHeaders(TransmissionParams *tp) {
   tp->headers.tx.ExtId = MMR_CAN_HeaderToBits(tp->headers.mmr);
 }
-- 
2.52.0


From 97b113fc91698e5b312b0182e5577b8dde6ce248 Mon Sep 17 00:00:00 2001
From: Stefano Calabretti <StefanoCalabretti@outlook.it>
Date: Tue, 10 May 2022 17:43:27 +0200
Subject: [PATCH 2/3] Fix send bug

---
 .gitignore         |  3 ++-
 Src/mmr_can_send.c | 14 +++++++-------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8c76af6..ac572a3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
 !.vscode/settings.json
-.vscode
\ No newline at end of file
+.vscode
+.DS_Store
\ No newline at end of file
diff --git a/Src/mmr_can_send.c b/Src/mmr_can_send.c
index e62c621..5e7a3a3 100644
--- a/Src/mmr_can_send.c
+++ b/Src/mmr_can_send.c
@@ -14,7 +14,7 @@ typedef struct {
 } TransmissionParams;
 
 
-static TransmissionParams buildParams(CanHandle *hcan, MmrCanPacket packet);
+static TransmissionParams buildParams(CanHandle *hcan, MmrCanPacket *packet);
 static HalStatus send(TransmissionParams *tp);
 static HalStatus sendNormal(TransmissionParams *tp);
 static HalStatus sendMulti(TransmissionParams *tp);
@@ -34,7 +34,7 @@ static uint8_t __currentMailbox = 0;
 
 HalStatus MMR_CAN_Send(CanHandle *hcan, MmrCanPacket packet) {
   TransmissionParams tp =
-    buildParams(hcan, packet);
+    buildParams(hcan, &packet);
 
   syncHeaders(&tp);
   return packet.length <= MMR_CAN_MAX_DATA_LENGTH
@@ -45,21 +45,21 @@ HalStatus MMR_CAN_Send(CanHandle *hcan, MmrCanPacket packet) {
 
 HalStatus MMR_CAN_SendNoTamper(CanHandle *hcan, MmrCanPacket packet) {
   TransmissionParams tp =
-    buildParams(hcan, packet);
+    buildParams(hcan, &packet);
 
   return send(&tp);
 }
 
 
-static TransmissionParams buildParams(CanHandle *hcan, MmrCanPacket packet) {
+static TransmissionParams buildParams(CanHandle *hcan, MmrCanPacket *packet) {
   return (TransmissionParams) {
     .handle = hcan,
-    .packet = &packet,
-    .headers.mmr = packet.header,
+    .packet = packet,
+    .headers.mmr = packet->header,
     .headers.tx = {
       .IDE = CAN_ID_EXT,
       .RTR = CAN_RTR_DATA,
-      .DLC = packet.length,
+      .DLC = packet->length,
       .TransmitGlobalTime = DISABLE,
     },
   };
-- 
2.52.0


From b47c2aaf88220a5dbe1de549b1401161b0c3e9ea Mon Sep 17 00:00:00 2001
From: Stefano Calabretti <StefanoCalabretti@outlook.it>
Date: Tue, 10 May 2022 20:21:42 +0200
Subject: [PATCH 3/3] Refactor

---
 Src/mmr_can_send.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Src/mmr_can_send.c b/Src/mmr_can_send.c
index 5e7a3a3..6c4d613 100644
--- a/Src/mmr_can_send.c
+++ b/Src/mmr_can_send.c
@@ -118,7 +118,10 @@ static HalStatus send(TransmissionParams *tp) {
 
 
 static CanMailbox *getNextMailbox() {
-  return &__mailboxes[__currentMailbox++ % MAILBOXES_COUNT];
+  __currentMailbox++;
+  __currentMailbox %= MAILBOXES_COUNT;
+
+  return __mailboxes + __currentMailbox;
 }
 
 
-- 
2.52.0