Minor comment clarifications

This commit is contained in:
2026-06-09 09:50:21 +02:00
parent 770e97ccd9
commit c891681b94
2 changed files with 7 additions and 9 deletions
+5 -6
View File
@@ -6,8 +6,7 @@
extern CAN_HandleTypeDef hcan1; extern CAN_HandleTypeDef hcan1;
extern CAN_HandleTypeDef hcan2; extern CAN_HandleTypeDef hcan2;
/* FreeRTOS task definitions */ /* USER CODE BEGIN RTOS_TASKS */
/* Definitions for CAN1rx incoming */ /* Definitions for CAN1rx incoming */
osThreadId_t vCAN1_rx; osThreadId_t vCAN1_rx;
const osThreadAttr_t vCAN1_rx_attributes = { const osThreadAttr_t vCAN1_rx_attributes = {
@@ -39,6 +38,8 @@ const osThreadAttr_t vLED_CAN2_Heartbeat_attributes = {
.stack_size = 128 * 4, .stack_size = 128 * 4,
.priority = (osPriority_t) osPriorityLow, .priority = (osPriority_t) osPriorityLow,
}; };
/* USER END RTOS_TASKS */
/* Private function prototypes -----------------------------------------------*/ /* Private function prototypes -----------------------------------------------*/
void CAN_Logger_Init(CAN_HandleTypeDef *hcan1, CAN_HandleTypeDef *hcan2){} void CAN_Logger_Init(CAN_HandleTypeDef *hcan1, CAN_HandleTypeDef *hcan2){}
@@ -76,10 +77,8 @@ void vLED_HeartbeatOnCanRx(void *argument)
for(;;) for(;;)
{ {
//TODO: add condition -> led High only when CANrx //HAL_GPIO_WritePin(led->port, led->pin, GPIO_PIN_RESET);
// else led Low // if semaphore for canrx, do the rest
// Depends on can log functions
// Use semaphore or message queue
HAL_GPIO_TogglePin(led->port, led->pin); HAL_GPIO_TogglePin(led->port, led->pin);
vTaskDelay(pdMS_TO_TICKS(100)); vTaskDelay(pdMS_TO_TICKS(100));
+2 -3
View File
@@ -107,11 +107,10 @@ int main(void)
MX_CAN1_Init(); MX_CAN1_Init();
MX_CAN2_Init(); MX_CAN2_Init();
MX_SDIO_SD_Init(); MX_SDIO_SD_Init();
/* USER CODE BEGIN 2 */ /* USER CODE BEGIN 2 */
/* Initialize CAN1 and CAN2 */
// Initialize CAN1 and CAN2
CAN_Logger_Init(&hcan1, &hcan2); CAN_Logger_Init(&hcan1, &hcan2);
/* USER CODE END 2 */ /* USER CODE END 2 */
/* Init scheduler */ /* Init scheduler */