mmr/Livox-SDK
Archived
1
0
Fork 0
Code Issues 105 Pull Requests 11 Actions Packages Projects Releases 9 Wiki Activity

Public thirdparty includes #140

New Issue
Open
opened 2021-08-27 20:06:29 +02:00 by efimov-evgeniy · 0 comments
efimov-evgeniy commented 2021-08-27 20:06:29 +02:00 (Migrated from github.com)
Copy Link
Copy Source

In sdk_core/CMakeLists.txt thirdparty includes (spdlog, FastCRC) added as PUBLIC. This leads to problems if the project is linked to livox_sdk_static and to a different version of sdplog, for example. I suggest to make such inсludes PRIVATE.

In [`sdk_core/CMakeLists.txt` ](https://github.com/Livox-SDK/Livox-SDK/blob/05cc408e54bce90863cd4f160992a92ddea1fd29/sdk_core/CMakeLists.txt#L15) thirdparty includes (spdlog, FastCRC) added as `PUBLIC`. This leads to problems if the project is linked to `livox_sdk_static` and to a different version of `sdplog`, for example. I suggest to make such inсludes PRIVATE.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
eeeck (Erick)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mmr/Livox-SDK#140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?