Use semaphores and one shot RTOS timers to better manage LEDs for incoming CAN message on FIFO buffer #8

2026-06-14T14:23:57+02:00

eeeck commented

2026-06-14 14:23:57 +02:00

No description provided.

eeeck added the enhancement label 2026-06-14 14:23:57 +02:00

eeeck added 5 commits 2026-06-14 14:23:58 +02:00

Change periodic timers to one shot timers c65341c662

Create semaphores for signalling new message in FIFO buffer 7c7d774522

Change variable name d6ea04e33e

Write HIGH status on LED on incoming CAN message and start 25ms timer 2e2150ebd2

Write LOW status on LED when timer triggers ebbd1816fa

eeeck added a new dependency 2026-06-14 14:24:15 +02:00

#1 CAN1/CAN2 LEDs may remain turned on when no CANrx

eeeck removed a dependency 2026-06-14 14:24:44 +02:00

#1 CAN1/CAN2 LEDs may remain turned on when no CANrx

eeeck added a new dependency 2026-06-14 14:24:57 +02:00

#1 CAN1/CAN2 LEDs may remain turned on when no CANrx

eeeck self-assigned this 2026-06-14 14:25:26 +02:00

eeeck marked the pull request as work in progress 2026-06-14 14:26:20 +02:00

eeeck added 4 commits 2026-06-14 14:51:50 +02:00

Move declaration on top 7ece650f72

Release semaphore on incoming message 1b38c0f29a

- Discard previous solution with timer only

Acquire semaphore and restart timer if new message incoming de6dc24dd3

Start timer once for automatic rearming with semaphore release 5f1695dc0d

eeeck added 1 commit 2026-06-14 15:13:29 +02:00

Avoid having to declare additional variable 5b500d72ff

eeeck added 2 commits 2026-06-14 15:17:18 +02:00

Create context structure for timer callback a75d42faeb

Strucure is made of
-  LED (port, pin)
- Semaphore
- Timer handle

Use new context structure instead of direct pass 75efc4840d

eeeck force-pushed led-semaphore from 643cac8ea6 to 75efc4840d

2026-06-14 15:17:18 +02:00

Compare

eeeck added 5 commits 2026-06-14 16:10:41 +02:00

Fix typo 151bac7a13

Remove unnecessary declarations 2a3d5d17b3

Use more clear variable names 72ffb2644e

Move below timer setup f0d2990b8d

Use a more sensible number of semaphores ac16f8150e

eeeck added 2 commits 2026-06-14 16:16:19 +02:00

Change CODE BEGIN N value 4aafa81009

Move typedef to header 8777f742ac

eeeck added 2 commits 2026-06-14 16:22:02 +02:00

Add CMSIS include 5ec806ffea

Fix race condition that could cause a hard fault 9d4d807cfb

eeeck force-pushed led-semaphore from 0587cf9756 to 9d4d807cfb

2026-06-14 16:22:02 +02:00

Compare

eeeck added 1 commit 2026-06-14 16:45:08 +02:00

Remove error handling as it would cause crash on full queue 53772ccb7d

eeeck marked the pull request as ready for review 2026-06-14 16:45:16 +02:00

eeeck merged commit 5a3223af29 into j1939

2026-06-14 16:49:18 +02:00

eeeck deleted branch led-semaphore

2026-06-14 16:49:18 +02:00

eeeck added this to the Thesis SCRUM project 2026-06-14 16:50:32 +02:00

eeeck moved this to In Progress in Thesis SCRUM on 2026-06-14 16:50:41 +02:00

eeeck moved this to Done in Thesis SCRUM on 2026-06-14 16:50:42 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Depends on

#1 CAN1/CAN2 LEDs may remain turned on when no CANrx

eeeck/CANdigger

Reference: eeeck/CANdigger#8