eeeck/CANdigger
1
0
Fork 1
Code Issues 7 Pull Requests 1 Actions Projects 1 Releases 6 Wiki Activity

Implement task for sending CAN data via UART #21

Merged
eeeck merged 71 commits from dev_serial-send into main 2026-06-18 15:35:23 +02:00
Conversation 0 Commits 71 Files Changed 15
+7857 -644
eeeck commented 2026-06-17 08:44:35 +02:00
Owner
Copy Link
Copy Source
No description provided.
eeeck added this to the v0.1.0 milestone 2026-06-17 08:44:35 +02:00
eeeck added the feature label 2026-06-17 08:44:35 +02:00
eeeck self-assigned this 2026-06-17 08:44:35 +02:00
eeeck added this to the Thesis SCRUM project 2026-06-17 08:44:35 +02:00
eeeck added 33 commits 2026-06-17 08:44:36 +02:00
Enable UART interface from MXCube 990a85c002
Increase UART baudrate cc3a37ba4b
Remove semaphores in favor of task notifications 6446f5209b 
- Less overhead, simpler to manage
- Semaphores are apparently overkill for a simple blink timer
Return instead of critical error 7d40531250 
- To find a way to handle overflows on the FIFO buffer
Fix spacing 266efdfa7c
Remove LED contexts 34df5e51b7 
- Are now unnecessary with the move to task notification
Remove unecessary MXCube comments af4ce2f9e8
Use clearer variable name 12ef44d3d8
Use define instead of hardcoded value f260dfe972
Merge pull request 'Switch to task notification from semaphore' (#20) from dev_task-notification into dev_serial-send cedd6cc0f8 
Reviewed-on: erickahmed/j1939_logger#20
Initialize UART task and semaphore and CAN event flags 76628dec90
Set CAN event flag and LED thread flag in ISR ac5d9f6a72 
- This is efficient specifically for
  STM32F4x with Thumb-2 IT block
  optimization enabled (-02 or -03)
Initialize cansend headers 0d0e485193
Implement safe UART semaphore release inside ISR 8b1b3b7ff3 
- It uses safe way to release semaphore
- Yields in case task interrupted was of lower priority: UART has
  minimal latency
Implement hex converter 84980d2378 
- Avoids snprintf
- Can be read from minicom/screen, but it's also friendly for other MCU
- This single function was AI generated
Add comment headers bc71cd7371
Remove not useful comment blocks 59274272d3 
- Not really used by CubeMX so worth removing
Fix comment blocks and function descriptions da1c13fcb0
Wait until CAN1 or CAN2 save anything to FIFO buffer 79f317cec5 
- Moving CAN event flag to vCANLoggerListen to avoid possible race
  condition and to make ISR leaner
Non-blocking on CAN1 queue check 3691918196 
- Check queue instantly
- Use DMA to move tx_buffer to UART peripheral
- Use a semaphore to DMA is being done, to avoid moving to next loop
  iteration and overwriting tx_buffer
- HAL_UART_TxCpltCallback will release semaphore when DMA done
Implement identical queue drain for CAN2 to that of CAN1 74bf4bde77
Revert decision on moving CAN event flag outside ISR 5f11cf5213 
- Would have caused destruction of the queue data itself
Refactor: implement data relay from vCANLoggerListen to xUARTQueue 59b0aca092 
- No RTOS event, just queue put and get: cleaner way to send data and
  more clear separation of concerns
Fix linker error by moving RTOS thread declaration to global scope dfc116b2e9
Remove dead code c540ff7800
Increase all queue sizes and double the UART queue 7d5b3f9be2
Use better name for CAN listener task function 24e100cae6
Remove whitespace cd0b412d74
Small variable name change e123c0172f
Fix task priority with correct handles f7581d49ce
Add externs cbefb45099
Fix typo in comment 8ec62d9fcd
Switch ISR semaphore release to normal semaphore release 6bcc977c65
eeeck moved this to In Progress in Thesis SCRUM on 2026-06-17 08:44:44 +02:00
eeeck added a new dependency 2026-06-17 08:45:07 +02:00
#5 Send CAN data to serial
eeeck force-pushed dev_serial-send from d69cb0231b to a6daf6c172 2026-06-17 18:07:14 +02:00 Compare
eeeck added 1 commit 2026-06-17 18:07:28 +02:00
Removing duplicate, again... 6ad1acc2ee
eeeck force-pushed dev_serial-send from a6daf6c172 to 6ad1acc2ee 2026-06-17 18:07:28 +02:00 Compare
eeeck added 14 commits 2026-06-17 20:52:29 +02:00
Removing duplicate, again... d69cb0231b
Implement ITM debug via ST-Link 84ea393dd6 
- Enable Instrumentation Trace Macroblock
- Remove PB3 initialization conflict with ITM
- Add a bunch of debug prints
Fix spacing 63e3e81986
Include main header 91218e782e
Add debug messages for UART 17c500e39a
Include stdint 5c8961efa7
Move to proper block 1d70a35f95
Initialize JTAG hardware 9980dafb5c 
- To debug with ST-Link
Use serial mode instad of JTAG 5e28758a5e
Update LED struct aeb553994c
Testing: SDIO stuff deactivated until implemented 60849ebb78 
- Goes into error handling
Move to PFP block in main.c and use more standard logic 907c0b170d
Return exact length 4afa6702fb
Merge branch 'dev_debug' into dev_serial-send 8d0b508ff6
eeeck added 1 commit 2026-06-17 21:45:22 +02:00
Fix declaration bug 7b30c3cedd
eeeck added 1 commit 2026-06-18 08:29:27 +02:00
Add USART DMA in Normal mode from CubeMX 4967cd9b32
eeeck force-pushed dev_serial-send from 604e9e603b to 4967cd9b32 2026-06-18 08:29:27 +02:00 Compare
eeeck added 1 commit 2026-06-18 08:44:33 +02:00
Enable CAN bus NVIC interrupts with higher priority 052d3fc5c0 
- This was blocking the CPU from vectoring to
  HAL_CAN_RxFifo0MsgPendingCallback
eeeck added 1 commit 2026-06-18 09:01:34 +02:00
Fix baudrates 691d5dc1ea 
- They were wrongly calculated on 168MHz but APB1 bus is at 42 MHz (168
  / 4)
eeeck added 3 commits 2026-06-18 09:10:08 +02:00
Fix typo ce25cba61b
Fix debug prints e951eaef7c
Make debug print safer by checking if ST-Link debugger is connected 11e50b05e4
eeeck added 1 commit 2026-06-18 09:11:57 +02:00
Accept for standard IDs and extended IDs bb70e0675a
eeeck added 4 commits 2026-06-18 13:08:18 +02:00
Start 9d96b3d4f2
Initialize semaphore with count of 1 b9c371ed58
Fix spacing 3bf5a8cc19
Fix buffer overwrite while DMA is not completed 9086bf3efb
eeeck added 1 commit 2026-06-18 13:24:39 +02:00
Move debugger connection check to main 9f1e7ba267
eeeck force-pushed dev_serial-send from 86398ebcff to 9f1e7ba267 2026-06-18 13:24:39 +02:00 Compare
eeeck added 1 commit 2026-06-18 13:42:22 +02:00
Fix spacing 5a91a56e27
eeeck added 5 commits 2026-06-18 13:43:43 +02:00
Add USART DMA in Normal mode from CubeMX 604e9e603b
Add debug print after 1s of no CAN traffic 825ddc6961
Add debug dummy CAN frame sent regularly ef034f3195 
- Activated by defining DEBUG_DUMMY_FRAME
Change define name 1ad8e5b04f 
- "DEBUG" is also used by STM32 for... something...
Merge branch 'stm_debug' into dev_serial-send 6f8d2a12ea
eeeck added 2 commits 2026-06-18 15:03:05 +02:00
Implement better ciclical method for dummy CAN frame sent on debug 41de3851f2
Enable USART1 global interrupt 33a2cc8fb4
eeeck added 1 commit 2026-06-18 15:05:56 +02:00
Check semaphore acquire status 2880ae64dc
eeeck force-pushed dev_serial-send from a5067fd9a9 to 2880ae64dc 2026-06-18 15:05:56 +02:00 Compare
eeeck added 1 commit 2026-06-18 15:15:59 +02:00
Fix spacing adcdc8b340
eeeck marked the pull request as ready for review 2026-06-18 15:33:15 +02:00
eeeck merged commit 5b5edc2ead into main 2026-06-18 15:35:23 +02:00
eeeck deleted branch dev_serial-send 2026-06-18 15:35:23 +02:00
eeeck moved this to Done in Thesis SCRUM on 2026-06-18 15:36:14 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 docs
Documentation related issue
 enhancement
Enchancement on an existing feature
 experimental
Experimental stuff
 feature
A new feature
 hardware
Hardware related issue
 invalid
Something is wrong
 minor
Small changes
 not planned
Feature not planned
 test
Testing/flashing related issues
No Label feature
Milestone
No items
No Milestone v0.1.0
Projects
Clear projects
No project Thesis SCRUM
Assignees
Clear assignees
eeeck (Erick)
No Assignees eeeck
1 Participants
Notifications
Due Date
No due date set.
Depends on
#5 Send CAN data to serial
eeeck/CANdigger
Reference: eeeck/CANdigger#21
Delete Branch "dev_serial-send"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?