Merge pull request 'Implement CAN bus reading with CMSIS-RTOS-V2' (#14) from j1939 into main #14

2026-06-14T21:43:14+02:00

eeeck commented

2026-06-14 21:43:14 +02:00

Features implemented:

RTOS based CAN bus reading
RTOS queue writing of each CAN frame
RTOS semaphore and timer based LED signalling
Removed Debug related directories and other minor leftovers

Features implemented: - [x] RTOS based CAN bus reading - [x] RTOS queue writing of each CAN frame - [x] RTOS semaphore and timer based LED signalling - [x] Removed Debug related directories and other minor leftovers

eeeck added this to the v0.1.0 milestone 2026-06-14 21:43:14 +02:00

eeeck added the feature test labels 2026-06-14 21:43:14 +02:00

eeeck self-assigned this 2026-06-14 21:43:14 +02:00

eeeck added this to the Thesis SCRUM project 2026-06-14 21:43:14 +02:00

eeeck added 71 commits 2026-06-14 21:43:15 +02:00

Add extern declaration for CAN handles 3c6e44821c

Update drivers and middleware f9c94efca5

- Generated from STM32CubeMX

Initialize CAN related tasks for logging and signaling 13de1b6c47

Initialize tasks for:
- CAN log incoming frames
- CAN blink on CANrx

Move CAN prototypes to relative include file e24f57e77f

Use correct thread arguments for CANrx threads a82734cef0

Move thread handles and attributes to related file 29284ceb87

- Better separation of concerns

Pass LED pin to thread arguments 714ca43d45

- Create typedef for LED (port:pin)
- Define two LED as private variables
- Pass them to threads

Move thread creation inside comment block 41084eb4d2

- Avoid overwrites from STM32CubeMX

Remove explicit cast 9f3d681134

Add simple GPIO toggling in RT a236377784

Minor changes on comments bbdb278338

- Clarifications on existing comments
- Add TODO

Remove trailing newlines b92b26b026

Minor clarification on existing comment c274be6907

Enable auto wake up on CAN traffic for future sleep mode 495c9cb377

Refactor task function name 5d3c8c0ec0

Move include declaration to private includes 770e97ccd9

Minor comment clarifications c891681b94

Use HAL WritePin func instead of TogglePin 30b7538e26

- Better reliability in blinking LED
- Slightly more efficiency (fewer CPU clocks)

Configure filter banks and start CAN 91385d00cf

Adapt error handler to log CAN errors and toggle error LED 87e8ffc6fa

Add headers for better code regeneration compatibility with STM32CubeMX 7bb401762a

Lower priority for LED heartbeat b14cdfaccb

Clarify function prototype description e2b6d13364

Use more clear names for RTOS function prototypes 6c4a1368be

Use CMSIS-RTOS2 instead of FreeRTOS for consistency 0f6011d05b

Fix error handling for CAN bus 0b05331fff

Update function prototype names d32c03c8f0

Remove static declare b38d4d5403

Simplify CAN error code handler d641c8b915

Simplify CAN error code handler 0c3c93040b

Implement LED heartbeat with RTOS timers instead of threads 59a58d1f1f

- Less memory overhead (no stack allocation)
- Better timing accuracy (less jitter)
- CAN bus still has higher priority than timers

Reset LEDs in error handler de7c817471

Simplify CAN error code handler 7b913c8ab9

Change headers with better copyright comments 0e4b41647f

- Add SPDX License Identifier and copyright notice
- Add NOTICE.md

Minor: remove unused freertos.c

Merge branch 'rtos-timers' into j1939 ce995602e4

Refactor: move RTOS task definition back to main.c c101c77ba4

- Private functions remain on canlog.c
- Better consistency for when regenerating with CubeMX

Refactor naming conventions following FREERTOS guidelines 8e37c44eae

Enable interrupt when CAN frame received and stored in FIFO buffer 19eaee2674

Remove duplicate declaration 2cce753716

Create message queues for saving CAN frames 34553af0a7

Change error check structure dc3688d3d7

Handle ISR for CANrx by saving message in FIFO buffer 8ef0980510

Read CAN messages from FIFO buffer d42e5fce46

Change periodic timers to one shot timers c65341c662

Create semaphores for signalling new message in FIFO buffer 7c7d774522

Change variable name d6ea04e33e

Write HIGH status on LED on incoming CAN message and start 25ms timer 2e2150ebd2

Write LOW status on LED when timer triggers ebbd1816fa

Move declaration on top 7ece650f72

Release semaphore on incoming message 1b38c0f29a

- Discard previous solution with timer only

Acquire semaphore and restart timer if new message incoming de6dc24dd3

Start timer once for automatic rearming with semaphore release 5f1695dc0d

Avoid having to declare additional variable 5b500d72ff

Create context structure for timer callback a75d42faeb

Strucure is made of
-  LED (port, pin)
- Semaphore
- Timer handle

Use new context structure instead of direct pass 75efc4840d

Fix typo 151bac7a13

Remove unnecessary declarations 2a3d5d17b3

Use more clear variable names 72ffb2644e

Move below timer setup f0d2990b8d

Use a more sensible number of semaphores ac16f8150e

Change CODE BEGIN N value 4aafa81009

Move typedef to header 8777f742ac

Add CMSIS include 5ec806ffea

Fix race condition that could cause a hard fault 9d4d807cfb

Remove error handling as it would cause crash on full queue 53772ccb7d

Merge pull request 'Use semaphores and one shot RTOS timers to better manage LEDs for incoming CAN message on FIFO buffer' (#8 ) from led-semaphore into j1939 5a3223af29

Reviewed-on: erickahmed/j1939_logger#8

Use a more generic name as semaphore will be used by other tasks 17febf569a

Fix scope error by moving declaration 19eefc288b

Fix variable name mismatch 3c66a39a5d

Remove files that were misteriously duplicated... 9fc2f0b73b

Merge pull request 'Change headers with better copyright comments' (#13 ) ac212c4a0a

from code-licensing into j1939

Reviewed-on: erickahmed/j1939_logger#13

eeeck changed title from ~~Merge first compiling build~~ to Merge pull request '' (#9) from j1939 into main

2026-06-14 21:58:15 +02:00

eeeck marked the pull request as work in progress 2026-06-14 21:58:25 +02:00

eeeck changed title from ~~WIP: Merge pull request '' (#9) from j1939 into main~~ to WIP: Merge pull request 'Implement CAN bus reading with CMSIS-RTOS-V2' (#9) from j1939 into main

2026-06-14 21:59:03 +02:00

eeeck changed title from ~~WIP: Merge pull request 'Implement CAN bus reading with CMSIS-RTOS-V2' (#9) from j1939 into main~~ to WIP: Merge pull request 'Implement CAN bus reading with CMSIS-RTOS-V2' (#14) from j1939 into main

2026-06-14 21:59:24 +02:00

eeeck added the due date 2026-06-14

2026-06-14 22:00:19 +02:00

eeeck modified the due date from 2026-06-14 to 2026-06-15

2026-06-14 22:03:20 +02:00

eeeck manually merged commit c3b1ac24e3 into main

2026-06-15 10:30:45 +02:00

eeeck marked the pull request as ready for review 2026-06-15 10:31:23 +02:00

eeeck referenced this issue from a commit

2026-06-15 10:34:01 +02:00

Merge pull request 'Implement CAN read RTOS' (#14) from j1939 into main

eeeck moved this to Done in Thesis SCRUM on 2026-06-15 10:42:24 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

2026-06-15

Dependencies

No dependencies set.

Reference: eeeck/CANdigger#14